Add Polycone
#451
Merged
Add Polycone
#451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhagemann
added
enhancement
|
So, I updated the geometry in the splitted inverted coaxial example config file now, so that it will not affect anything in the ICPC tutorial. However, the Geant4 tests will now run with the polycone geometry to have some testing there. |
fhagemann
commented
Jan 22, 2025
| @@ -56,7 +56,7 @@ end | |||
| @testset "Run Geant4 simulations" begin | |||
|
|
|||
| # Create G4JLApplication | |||
| sim = Simulation{T}(SSD_examples[:InvertedCoax]) | |||
| sim = Simulation{T}(SSD_examples[:InvertedCoaxInCryostat]) | |||
There was a problem hiding this comment.
This way, we will also try out parsing another material and more geometries.
fhagemann
commented
Jan 23, 2025
so far for the ClosedPrimitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
polyconeto the geometries, which can be defined as a set of points inrandz:It follows the same logic as the G4GenericPolycone.
Note: I also updated the example inverted coaxial detector geometry to use
polyconeinstead of a difference oftubesandcones. The results seem to be identical (all tests still pass). However, we can discuss to revert this and to keep the original file as is (especially usingdifference, which might be good guidance for people wanting to do more complicated CSG stuff.This should close #449.